*: Make DDL unaffected by killing TiDB instance #43871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #43854
Problem Summary:
This issue support canceling DDL statements with KILL(related PR:*: fix a data race on TestConnExecutionTimeout #35923).
---The original PR that supported this didn't seem to say cancel DDL on "kill TiDB"
But after these PRs, when we do
kill TiDB
, this TiDB's DDLs may be canceled(In some cases it can't be cancelled).--- Cancel DDL is not fully supported in the case of "kill TiDB".
This issue need do "Pause user DDL when upgrading TiDB", but these DDLs may be canceled by
kill TiDB
. So we considerkill TiDB
can not cancel DDL.We'll deal with this in detail when we distinguish between asynchronous and synchronous DDLs.
What is changed and how it works?
If don't we kill TiDB can't cancel DDLs.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.